Add warning when module is missing in storiesOf #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Jul 26, 2017
|
Go ahead and merge @igor-dv 👏 |
bryanstearns
added a commit
to infinitered/ignite-bowser
that referenced
this pull request
Jan 26, 2019
The Storybook fix for this issue storybookjs/storybook#1525 adds a warning when `storiesOf` doesn’t have a `module` parameter. The `module` parameter is necessary to enable hot-module-replacement to work right: storybookjs/storybook#2022 (comment)
jamonholmgren
pushed a commit
to infinitered/ignite-bowser
that referenced
this pull request
Mar 11, 2019
The Storybook fix for this issue storybookjs/storybook#1525 adds a warning when `storiesOf` doesn’t have a `module` parameter. The `module` parameter is necessary to enable hot-module-replacement to work right: storybookjs/storybook#2022 (comment) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Based on conversation in #1506
What I did
I've added a warning when module parameter is not provided
How to test
cra-kitchen-sync