Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate broken when including dev screens #1061

Closed
carlosconnected opened this issue May 26, 2017 · 18 comments
Closed

Boilerplate broken when including dev screens #1061

carlosconnected opened this issue May 26, 2017 · 18 comments

Comments

@carlosconnected
Copy link

Hi there,

I'm facing a problem with the latest CLI 2.0.0-rc.1. I cannot run the boilerplate with dev screens. I keep getting the following error on both iOS and Android:

undefined is not an object (evaluating 'RNDeviceInfo.systemManufacturer')

It only occurs when including dev screen.

Any suggestions?

@derekgreenberg
Copy link
Member

Verified. I'm experiencing the same problem. Just tried it after updating to CLI 2.0.0-rc.1

@atonse
Copy link

atonse commented May 26, 2017

I'm getting a similar problem. Brand new boilerplate with dev screens:

missing "Examples/Components/animatableExample.js."

@atonse
Copy link

atonse commented May 26, 2017

After commenting out the import code that was requesting it, I am now getting the error that @carlos-peru is mentioning.

@skellock
Copy link
Contributor

Looks like the dependency is missing from https://github.com/infinitered/ignite-dev-screens/blob/master/plugin.js#L25 for react-native-device-info.

Short term fix in your current project.

npm i --save react-native-device-info
react-native link react-native-device-info

Until we get this patched up.

@derekgreenberg
Copy link
Member

derekgreenberg commented May 26, 2017

Verified the temporary fix from @skellock works. To test, ignite a new project. In the series of prompts presented as you ignite your new project, select 'Yes' when prompted Would you like Ignite Development Screens? and answer 'none' when prompted for What vector icon library will you use?, What internationalization library will you use? and What animation library will you use?. Then follow @skellock's instructions to manually add the dependencies your project needs for react-native-device-info. Issues with the vector icon, internationalization and animation libraries will be fixed ASAP.

@derekgreenberg
Copy link
Member

Verified that fixes to both ignite-cli and ignite-dev-screens have solved these errors.

To test, uninstall ignite-cli and re-install the latest version:

npm uninstall -g ignite-cli
npm install -g ignite-cli

ignite --version
2.0.0-rc.2

Generate a new app and install dev screens and all libraries when prompted.

@carlosconnected
Copy link
Author

Thanks a lot for the quick resolution!! Awesome project!!

@therealgilles
Copy link

therealgilles commented Apr 21, 2018

Is this supposed to be included in 2.0.0? I just got this error with this release.

@KamranKhankhail
Copy link

@derekgreenberg I have uninstalled ignite-cli and re-installed latest version that is currently 2.1.0 but issue is still there. I am unable to add redux-persist.

@jjm340
Copy link

jjm340 commented Sep 14, 2018

The dev screen content does not appear in the folder it's supposed to when I install a new app, this causes the bundler to fail.

@andretf
Copy link

andretf commented Sep 21, 2018

Same error in 2.1.1. My package.json has the dependency.
react-native link react-native-device-info fixed it.

@kevinvangelder
Copy link
Member

@andretf Would you mind filing that as an issue on the devscreens repo itself? We may not get around to fixing it as dev screens aren't used in Bowser, but the workaround may be useful to other users that hit the same problem. https://github.com/infinitered/ignite-dev-screens/issues/new

@andretf
Copy link

andretf commented Sep 22, 2018

Sure

@andyr6381
Copy link

New here, was having a similar issue using node 10 and devscreen folders not being created in the ignite folder, downgraded to node 7.6.0 and everything installed and worked normally.

@jamonholmgren
Copy link
Member

That's helpful, thanks @andyr6381 . Go ahead and comment on this issue: infinitered/ignite-dev-screens#14

@hunwalk
Copy link

hunwalk commented Oct 16, 2018

The boilerplate works with node v8.12.0 on macOS. Well however by default homebrew wants to install node v10.12.0 and with that version the boilerplate is kinda broken.

@hunwalk
Copy link

hunwalk commented Oct 16, 2018

Yeah, a slight problem. After the boilerplate was complete i 've had to run npm install because some dependencies were still missing. Is this necessary?

@jamonholmgren
Copy link
Member

To be honest, I'm not sure! @hunwalk if you could comment on the other issue (this repo is about the Ignite CLI), that might get more attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests