Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): warn macOS users about spaces in path #2550

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix(cli): warn macOS users about spaces in path #2550

merged 3 commits into from
Nov 14, 2023

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Nov 10, 2023 •
edited
Loading

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

  • Closes [!] Invalid Podfile file: cannot load such file -- ./scripts/autolinking. #2493
  • After some testing, you will encounter the error in the attached screenshot when there is a space in the pathname of the project directory on macOS
  • We'll warn the user on macOS that the requested project path contains spaces
  • This also adjusts the Podfile to at least fix Pod install (but the project will still not start on iOS, this needs to be fixed upstream in RN)

Screenshots

image

image

@frankcalise frankcalise changed the title fix(boilerplate): Podfile accounts for spaces in path fix(boilerplate): warn macOS users about spaces in path Nov 12, 2023
@frankcalise frankcalise changed the title fix(boilerplate): warn macOS users about spaces in path fix(cli): warn macOS users about spaces in path Nov 12, 2023
joshuayoes
joshuayoes approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@joshuayoes joshuayoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this constraint, but this looks like a good guard rail

@frankcalise frankcalise merged commit 1ec7e64 into master Nov 14, 2023
1 check passed
@frankcalise frankcalise deleted the fix/paths-with-space branch November 14, 2023 14:20
infinitered-circleci pushed a commit that referenced this pull request Nov 14, 2023
@semantic-release-bot
chore(release): 8.11.2 [skip ci]
c0543f7 
## [8.11.2](v8.11.1...v8.11.2) (2023-11-14)

### Bug Fixes

* **cli:** warn macOS users about spaces in path ([#2550](#2550) by [@frankcalise](https://github.com/frankcalise)) ([1ec7e64](1ec7e64))
@infinitered-circleci
Copy link

🎉 This PR is included in version 8.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuayoes joshuayoes joshuayoes approved these changes

@jamonholmgren jamonholmgren Awaiting requested review from jamonholmgren

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[!] Invalid Podfile file: cannot load such file -- ./scripts/autolinking.
3 participants
@frankcalise @infinitered-circleci @joshuayoes