Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Ignite New #567

Closed
GantMan opened this issue Dec 27, 2016 · 12 comments
Closed

[2.0] Ignite New #567

GantMan opened this issue Dec 27, 2016 · 12 comments
Milestone

Comments

@GantMan
Copy link
Member

GantMan commented Dec 27, 2016

ignite new should be started.

Take these examples as functional minimums. The actual experience can have spinners/friendly graphics etc.

version 1: Answers "no" to everything. Perfect for regen playground. Simply uses #568

ignite new SomeProject --min
Congrats! SomeProject has been generated

version 2: Answers "yes" to everything. Great for testing.

ignite new SomeProject --max
Congrats! SomeProject has been generated

version 3: Composer experience

ignite new SomeProject
Welcome to Ignite - The Unfair Headstart Generator

The following questions will help us choose your additional goodies.

Would you like the Ignite Development Screens? (y/n)
y
...
...
Congrats! SomeProject has been generated
@GantMan GantMan added this to the 2.0 milestone Dec 27, 2016
@GantMan GantMan added the TODO label Dec 27, 2016
@ericvera
Copy link

I've been playing with the v2 for the last couple of hours and have a v0.1 of the new command. It still needs some work, but thought I'd share it before investing too much on it. If this works let me know and I can create a pull request once I add a bit more validation. Otherwise let me know of any suggestions on a better approach.

Approach new.js:

  1. Create a new directory (<new app name>) under the current working directory
  2. Call ignite add ignite-basic-structure <new app name> using the new directory as the cwd

Considered Approach:

  • Call cli.js directly and require the ignite-basic-structure generator directly. Since each of those deal directly with the parameters passed to the command line, that would require refactoring the code to be able to pass the valued from the new command.

@kevinvangelder
Copy link
Member

@ericvera Looks like a great start to me, but @GantMan and @skellock are the real masterminds, so I'd look for their feedback before continuing. This already covers most of the functionality of the proposed --min option.

@ericvera
Copy link

There are a few things that I am still not sure what your intended design is. Did you intend to run react-native init <project name> (I have not added this yet) and then run the ignite-basic-structure generator?

@skellock
Copy link
Contributor

skellock commented Jan 22, 2017

Thanks for the input @ericvera. I'd like to see ignite-basic-structure rolled into ignite personally.

I think you'll see a lot of refinements next week though as the team is getting together in person.

And yes, our starting point is react-native init EricApp.

@skellock
Copy link
Contributor

@ericvera I just re-read your comment. I didn't realize what you were saying is: you're building it.

@GantMan has built new and we're just tweaking it now. We're going in stages. We've got unholy (what we're calling ignite 1's kitchen sink approach) up & running now, and we're going to bust those into plugins next.

I appreciate the help though. Perhaps what we can do is start tagging a few tasks with Help Wanted on Ignite 2 going forward.

@GantMan
Copy link
Member Author

GantMan commented Jan 22, 2017

awesome thoughts @ericvera - I think Ignite 2.0 in one week will look very different. Keep your ear to the ground here on github to see the transformation as we go through it 👍

@skellock skellock removed the TODO label Jan 22, 2017
@GantMan
Copy link
Member Author

GantMan commented Jan 22, 2017

@skellock , should this have been closed?

@skellock
Copy link
Contributor

I think so. ignite new has been built.

Feel free to open this up if you think i'm overlooking something.

@GantMan
Copy link
Member Author

GantMan commented Jan 22, 2017

Just thinking the --min --max hasn't been put in yet. The original ticket had those.

@skellock skellock reopened this Jan 22, 2017
@skellock
Copy link
Contributor

Okie dokie.

@kevinvangelder
Copy link
Member

@ericvera We made a lot of progress on 2.0 this week. Feel free to check out the latest code on next as well as the new issues we've filed to get an idea of where we could use help.

@skellock
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants