Handle warn output for packager.list #1994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's Left:
|
joshuayoes
changed the title
joshuayoes
commented
Aug 8, 2022
| @@ -104,7 +103,6 @@ export default { | |||
| // generate the project | |||
| startSpinner("Igniting app") | |||
| await spawnProgress(log(expoCLIString), { | |||
| env: cliEnv, | |||
There was a problem hiding this comment.
I removed this argument because it is not currently used in spawnProgress
joshuayoes
commented
Aug 8, 2022
Comment on lines
-33
to
-35
| const packageListOptions: PackageOptions = { | ||
| global: false, | ||
| } |
There was a problem hiding this comment.
Since this is only used by one function, I moved this option into a default argument on listCmd
joshuayoes
commented
Aug 8, 2022
Comment on lines
-27
to
-31
| const packageInstallOptions: PackageRunOptions = { | ||
| dev: false, | ||
| expo: false, | ||
| onProgress: (out: string) => console.log(out), | ||
| } |
There was a problem hiding this comment.
Not deleted, but moved lower in file
|
These changes should be implemented in gluegun instead of ignite: infinitered/gluegun#762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Resolves #1993 by parsing
spawnoutput as chunks of strings instead of one joined stringspawnChunkedtool, to grab command output from a spawned process as a array of string chunks instead of one joined stringlistfunction inpackagertool to use dependency injection for services, in order to make it easier to test specific use caseslistCmdcan handle unexpectedyarn listornpm listoutputs