fix(cli): pnpm npmrc #2561
Merged
fix(cli): pnpm npmrc #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+581
to
+583
| const npmrcPath = path(targetPath, ".npmrc") | ||
| const npmrcContents = read(npmrcPath) | ||
| write(npmrcPath, `${npmrcContents}${EOL}node-linker=hoisted${EOL}`) |
There was a problem hiding this comment.
FYI, gluegun has a built-in patching library that makes this a little simpler.
To keep the style elsewhere in this file don't use this, but as an (untested) example:
Suggested change
| const npmrcPath = path(targetPath, ".npmrc") | |
| const npmrcContents = read(npmrcPath) | |
| write(npmrcPath, `${npmrcContents}${EOL}node-linker=hoisted${EOL}`) | |
| const npmrcPath = path(targetPath, ".npmrc") | |
| await patching.append(npmrcPath, `${EOL}node-linker=hoisted${EOL}`) |
infinitered-circleci
pushed a commit
that referenced
this pull request
Nov 20, 2023
## [9.0.1](v9.0.0...v9.0.1) (2023-11-20) ### Bug Fixes * **cli:** pnpm npmrc ([#2561](#2561) by [@frankcalise](https://github.com/frankcalise) [@morganick](https://github.com/morganick)) ([4ae5c0b](4ae5c0b)) * **cli:** remove demo when spaces in path ([#2563](#2563) by [@frankcalise](https://github.com/frankcalise)) ([b5133a3](b5133a3))
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR
pnpmhad some troubles and requires additional config