Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boilerplate): jest.config.js remove jsdom test env #2632

Merged
merged 1 commit into from Feb 21, 2024
Merged

fix(boilerplate): jest.config.js remove jsdom test env #2632

merged 1 commit into from Feb 21, 2024

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Feb 11, 2024 •
edited

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

markrickert
markrickert requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankcalise I also just ran into this issue, but to fix it i had to remove the same property from the base package.json as well: https://github.com/infinitered/ignite/blob/master/package.json#L154

@frankcalise
Copy link
Contributor Author

@markrickert that was a result of running yarn test from the root project dir that you hit this error?

@markrickert
Copy link
Member

@frankcalise Sorry, false alarm... i'm getting a different error actually:

 FAIL  src/tools/demo.test.ts
  ● Test suite failed to run

    TypeError: Cannot read properties of undefined (reading 'testEnvironmentOptions')

      at new NodeEnvironment (node_modules/jest-environment-node/build/index.js:88:49)

Test Suites: 6 failed, 6 total

Though it's probably something i did in my branch.

@frankcalise frankcalise marked this pull request as ready for review February 13, 2024 20:37
@frankcalise frankcalise merged commit 22c7afc into master Feb 21, 2024
1 check passed
@frankcalise frankcalise deleted the fix/rntl-support branch February 21, 2024 16:56
infinitered-circleci pushed a commit that referenced this pull request Feb 21, 2024
@semantic-release-bot
chore(release): 9.6.1 [skip ci]
93064e4 
## [9.6.1](v9.6.0...v9.6.1) (2024-02-21)

### Bug Fixes

* **boilerplate:** jest.config.js remove jsdom test env for better RNTL support out of box ([#2632](#2632) by [@frankcalise](https://github.com/frankcalise)) ([22c7afc](22c7afc))
* **boilerplate:** remove `yarn prebuild` script in favor of clean ([#2635](#2635) by [@frankcalise](https://github.com/frankcalise)) ([f669a32](f669a32))
* **boilerplate:** web hmr fixes ([#2646](#2646) by [@frankcalise](https://github.com/frankcalise)) ([45aabb2](45aabb2))
* **cli:** Global Expo CLI checks in Doctor command ([#2618](#2618) by @Dax911) ([d0b2b2d](d0b2b2d))
* **components:** switch animation slide on web ([#2642](#2642) by [@frankcalise](https://github.com/frankcalise)) ([c0dcc6d](c0dcc6d))
@infinitered-circleci
Copy link

🎉 This PR is included in version 9.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markrickert markrickert markrickert approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError: Unexpected token '<' when running Jest
3 participants
@frankcalise @markrickert @infinitered-circleci