New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen generators via Plugin #498
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_base into screen_generator
This was referenced Nov 21, 2016
DO NOT MERGE - UPDATES COMING - review #488 |
Merged
3 tasks
3 tasks
25 commits - such awesome work done here. But alas, it started a movement and so it's really fine that it never got merged. Goodbye dear PR, I am excited to see you, and to see you go. From these ashes a better ignite has been born. |
Honourably discharged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen generators moved on to external generator.
This moves all screen generators (except maps) to use this instead.
When you ignite new screens/components etc, you're using the plugin system. This allows composition and extendability. This begins the plugin system for features.
Closes: #488
References: #153 - #170 - #191 - #358 - #447 - #457