fix: Display error if port is already in use #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
commented
Dec 7, 2023
|
|
||
| import SidebarStateless from "./Stateless" |
There was a problem hiding this comment.
Not really a fan of these Stateless.tsx files.
Apply Sweep Rules to your PR?
|
jamonholmgren
commented
Dec 7, 2023
| connections: Connection[] | ||
| selectedClientId: string | ||
| orphanedCommands: any[] // Command[] | ||
| commandListeners: ((command: any) => void)[] // ((command: Command) => void)[] | ||
| } | ||
|
|
||
| type Action = | ||
| | { type: ActionTypes.ServerStarted; payload: undefined } | ||
| | { type: ActionTypes.ServerStopped; payload: undefined } |
There was a problem hiding this comment.
I honestly think we should implement MobX-State-Tree in Reactotron. I am not a big fan of the useReducer & provider/context DX.
jamonholmgren
commented
Dec 7, 2023
| @@ -12,38 +12,32 @@ import { createServer } from "reactotron-core-server" | |||
| // configure a server | |||
| const server = createServer({ | |||
| port: 9090, // default | |||
|
|
|||
| onStart: () => null, // fires when we start the server | |||
There was a problem hiding this comment.
These examples were wrong. I fixed them.
joshuayoes
approved these changes
Dec 8, 2023
joshuayoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334.
This adds an icon to the left sidebar that indicates the server status: Stopped, Started, or Port Unavailable.
Clicking the icon reloads Reactotron, which is a quick & dirty way to attempt reconnection. In the future, we can handle it more elegantly.