Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a help icon and pushes a few pixels around. #135

Merged
merged 1 commit into from
Aug 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 28 additions & 18 deletions packages/reactotron-app/App/Dialogs/HelpDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import AppStyles from '../Theme/AppStyles'
import Colors from '../Theme/Colors'

const ESCAPE_KEYSTROKE = 'Esc'
const ESCAPE_HINT = 'Close Help'
const ESCAPE_HINT = 'Close'
const DIALOG_TITLE = 'Reactotron Quick-Help'
const INSTRUCTIONS = (
<span> Shortcut list</span>
Expand All @@ -27,8 +27,7 @@ const Styles = {
...AppStyles.Layout.hbox,
alignSelf: 'center',
paddingTop: 10,
paddingBottom: 20,
fontSize: 13
paddingBottom: 20
},
hotkey: {
padding: '0 10px'
Expand All @@ -48,7 +47,8 @@ const Styles = {
padding: '0.5em 2em 3em'
},
helpShortcut: {
flexDirection: 'row'
...AppStyles.Layout.hbox,
margin: '2px 0'
},
title: {
margin: 0,
Expand All @@ -67,14 +67,18 @@ const Styles = {
helpLabel: {
// borderBottom: `1px solid ${Colors.line}`,
color: Colors.bold,
fontSize: 13,
textTransform: 'uppercase',
paddingRight: 10
width: 100
},
helpDetail: {
fontSize: 13,
color: Colors.foregroundLight,
backgroundColor: 'inherit'
flex: 1
},
group: {
marginTop: 10,
marginBottom: 2,
paddingBottom: 2,
color: Colors.highlight,
borderBottom: `1px solid ${Colors.line}`
}
}

Expand All @@ -94,7 +98,7 @@ class StateDispatchDialog extends Component {

return (
<ModalPortal>
<ModalBackground onClose={ui.closeStateDispatchDialog}>
<ModalBackground onClose={ui.closeHelpDialog}>
<ModalDialog style={Styles.dialog}>
<div style={Styles.container}>
<div style={Styles.header}>
Expand All @@ -104,21 +108,27 @@ class StateDispatchDialog extends Component {
</p>
</div>
<div style={Styles.body}>
<div style={Styles.group}>Working With State</div>
<div style={Styles.helpShortcut}>
<div style={Styles.helpLabel}>Cmd + F</div>
<div style={Styles.helpDetail}>find keys or values</div>
</div>
<div style={Styles.helpShortcut}>
<label style={Styles.helpLabel}>Cmd + F</label>
<label style={Styles.helpDetail}>find Redux keys or values (use tab to toggle)</label>
<div style={Styles.helpLabel}>Cmd + N</div>
<div style={Styles.helpDetail}>new subscription</div>
</div>
<div style={Styles.helpShortcut}>
<label style={Styles.helpLabel}>Cmd + N</label>
<label style={Styles.helpDetail}>subscribe to a Redux path</label>
<div style={Styles.helpLabel}>Cmd + D</div>
<div style={Styles.helpDetail}>dispatch an action</div>
</div>
<div style={Styles.group}>Miscellaneous</div>
<div style={Styles.helpShortcut}>
<label style={Styles.helpLabel}>Cmd + D</label>
<label style={Styles.helpDetail}>dispatch a Redux action</label>
<div style={Styles.helpLabel}>Cmd + K</div>
<div style={Styles.helpDetail}>klear!</div>
</div>
<div style={Styles.helpShortcut}>
<label style={Styles.helpLabel}>Cmd + K</label>
<label style={Styles.helpDetail}>klear!</label>
<div style={Styles.helpLabel}>Cmd + /</div>
<div style={Styles.helpDetail}>toggle help</div>
</div>
</div>
<div style={Styles.keystrokes}>
Expand Down
24 changes: 23 additions & 1 deletion packages/reactotron-app/App/Foundation/Header.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,48 @@
import React, { Component } from 'react'
import Colors from '../Theme/Colors'
import AppStyles from '../Theme/AppStyles'
import HelpIcon from 'react-icons/lib/md/help'
import ReactTooltip from 'react-tooltip'
import { inject, observer } from 'mobx-react'

const Styles = {
container: {
WebkitAppRegion: 'drag'
},
content: {
padding: '10px 10px',
backgroundColor: Colors.chrome,
height: 60,
borderBottom: `1px solid ${Colors.chromeLine}`,
color: Colors.foregroundDark,
boxShadow: `0px 0px 30px ${Colors.glow}`
},
toolbar: {
...AppStyles.Layout.hbox,
justifyContent: 'flex-end',
alignItems: 'center'
},
tooltip: {
backgroundColor: Colors.backgroundLight,
padding: 10
}
}

@inject('session')
@observer
class Header extends Component {

render () {
const { ui } = this.props.session
return (
<div style={Styles.container}>
<div style={Styles.content}>
<div style={Styles.toolbar}>
<HelpIcon size={30} data-tip onClick={ui.openHelpDialog} />
</div>
</div>
<ReactTooltip place='left' className='tooltipTheme'>
<p>Need Some Help?</p>
</ReactTooltip>
</div>
)
}
Expand Down
1 change: 0 additions & 1 deletion packages/reactotron-app/App/Foundation/VisualRoot.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export default class VisualRoot extends Component {
<StateDispatchDialog />
<HelpDialog />
<StateWatchDialog />
<ReactTooltip />
</div>
)
}
Expand Down
8 changes: 6 additions & 2 deletions packages/reactotron-app/App/Stores/UiStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ class UI {
Mousetrap.bind('command+k', this.reset)
Mousetrap.bind('command+f', this.openStateFindDialog)
Mousetrap.bind('command+d', this.openStateDispatchDialog)
Mousetrap.bind('command+/', this.openHelpDialog)
Mousetrap.bind('command+?', this.openHelpDialog)
Mousetrap.bind('command+/', this.toggleHelpDialog)
Mousetrap.bind('command+?', this.toggleHelpDialog)
Mousetrap.bind('tab', this.toggleKeysValues)
Mousetrap.bind('escape', this.popState)
Mousetrap.bind('enter', this.submitCurrentForm)
Expand Down Expand Up @@ -122,6 +122,10 @@ class UI {
this.showStateDispatchDialog = true
}

@action toggleHelpDialog = () => {
this.showHelpDialog = !this.showHelpDialog
}

@action openHelpDialog = () => {
this.showHelpDialog = true
}
Expand Down
4 changes: 4 additions & 0 deletions packages/reactotron-app/App/app.global.css
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,7 @@ a.closeButton--jss-0-1 { display: none; }
0% { -webkit-transform: translateY(0px); }
100% { -webkit-transform: translateY(100%); }
}

.tooltipTheme {
background-color: 'green'
}