-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinum/feature/spm-carthage #31
Infinum/feature/spm-carthage #31
Conversation
…le name for BundleHelpers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with this PR until everything else is finished. For now, I'm only concerned with the lib renaming that we should avoid.
The lib name was renamed since we had a discussion when I tried to add SPM support the first time. I posted an error which I had to #team-ios channel and we thought that the name was giving us problems. But in the end, it wasn't. It had to do something with the lib being obj-c, now it works with the same name as the target name. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implemented SPM and left .xcodeproj so we can use that if we want just to test out the pod version instead of Package.swift.
EDIT: prepared project for carthage support. In root folder run "carthage build --no-skip-current --use-xcframeworks --archive" to create Locker.framework.zip.