Infinum/feature/spm-carthage #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le name for BundleHelpers
jabou
reviewed
Nov 4, 2021
|
The lib name was renamed since we had a discussion when I tried to add SPM support the first time. I posted an error which I had to #team-ios channel and we thought that the name was giving us problems. But in the end, it wasn't. It had to do something with the lib being obj-c, now it works with the same name as the target name. 😄 |
ZvonimirMedak
changed the base branch from
infinum/feature/apiary
to
infinum/update/documentation
jabou
requested changes
Nov 22, 2021
|
Edit: one thing that comes to mind is that the deletion didn't commit and if you switched from another branch to this one it didn't delete it. |
jabou
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented SPM and left .xcodeproj so we can use that if we want just to test out the pod version instead of Package.swift.
EDIT: prepared project for carthage support. In root folder run "carthage build --no-skip-current --use-xcframeworks --archive" to create Locker.framework.zip.