This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Adapter method updates #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I don't think the |
|
I agree with @reisub Do we have a removeHeader/Footer methods? If not I think we should have it. There could be a need to remove it after inital set, do you agree? |
|
Or maybe we could remove by setting it to null. Here we should take a look
at the listview API since it has similar features.
On Fri, Feb 24, 2017, 17:07 Ivan Marić ***@***.***> wrote:
I agree with @reisub <https://github.com/reisub> shouldReplace is
unnecessary. Return type can be void and you need to update javadoc.
Do we have a removeHeader/Footer methods? If not I think we should have
it. There could be a need to remove it after inital set, do you agree?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8mQz7k2MkdOW734zyegdG7WgeUSzTaks5rfwAmgaJpZM4MLA-v>
.
--
Android Team Lead • Infinum
+385 95 911 6324
infinum.co
|
mariciv
reviewed
Feb 27, 2017
| headerView = LayoutInflater.from(getContext()).inflate(headerViewId, null, false); | ||
| setDefaultLayoutParams(headerView); | ||
|
|
||
| if (hadHeaderBefore) { |
There was a problem hiding this comment.
You could call setHeader(View) method to avoid duplicate logic.
mariciv
reviewed
Feb 27, 2017
| boolean hadFooterBefore = hasFooter(); | ||
|
|
||
| int position = getCollectionCount() + (hasHeader() ? 1 : 0); | ||
| footerView = LayoutInflater.from(getContext()).inflate(footerViewId, null, false); |
There was a problem hiding this comment.
The same as for the header. You can call setFooter(View) to avoid duplicate logic.
mariciv
approved these changes
Feb 27, 2017
|
@reisub all comments have been resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated methods in order to prepare Mjolnir for 2.0.0 release.
Also, I've renamed addFooter/addHeader methods to setFooter/setHeader, as they are more precise - if we use "add" keyword, it immediately signals that we are supporting multiple headers/footers, which is still not the case.