Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobx strict-mode error on save #69

Closed
re5et opened this issue Sep 5, 2018 · 2 comments
Closed

mobx strict-mode error on save #69

re5et opened this issue Sep 5, 2018 · 2 comments
Labels

Comments

@re5et
Copy link

re5et commented Sep 5, 2018

mobx.module.js:2655 Uncaught (in promise) Error: [mobx] Since strict-mode is enabled, changing observed observable values outside actions is not allowed. Please wrap the code in an `action` if this change is intended. Tried to modify: ObservableObject@173.meta.jsonapiPersisted

We are seeing the above error when saving changes to a model. I am not super experienced with mobx, but it seems like https://github.com/infinum/datx/blob/master/packages/datx-jsonapi/src/NetworkUtils.ts#L368 isn't marked as an action anywhere?

@DarkoKukovec
Copy link
Member

Thanks for reporting the issue. It should be fixed in the newly published version 0.11.5

@re5et
Copy link
Author

re5et commented Sep 6, 2018

Looks to have solved the problem where I was seeing it 👍

re5et added a commit to ideo/shape that referenced this issue Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants