Feature/get response raw data #1160
Conversation
kristian240
requested review from
DarkoKukovec and
isBatak
and removed request for
DarkoKukovec
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -7,17 +7,17 @@ To apply the mixin to your models and collections, use the `jsonapi` method. Eve | |||
|
|
|||
| ```typescript | |||
| import { Collection, Model } from '@datx/core'; | |||
| import { config, jsonapi } from '@datx/jsonapi'; | |||
| import { config, jsonapiModel } from '@datx/jsonapi'; | |||
There was a problem hiding this comment.
What's the reasoning here to use jsonapiModel and collection instead of the jsonapi mixin? My thinking was to decrease the API surface and only have one function for everything.
There was a problem hiding this comment.
I would assume that we don't want to bundle parts we do not need (static vs runtime). For example, view is something that is not used that often but it is being part of every app that uses datx.
There was a problem hiding this comment.
@isBatak can you give your 2 cents on this one?
There was a problem hiding this comment.
@DarkoKukovec Are we okay with this then? If yes, can someone approve the PR? 😄
Please select all that apply:
Please describe the differences between the current and new behavior