Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsonapi-angular)!: refactor Angular setup #1169

Merged
merged 5 commits into from
Apr 21, 2023
Merged

feat(jsonapi-angular)!: refactor Angular setup #1169

merged 5 commits into from
Apr 21, 2023

Conversation

fvoska
Copy link
Contributor

@fvoska fvoska commented Apr 20, 2023

Please select all that apply:

  • This PR contains a new feature
  • This PR updates an existing feature
  • This PR contains bugfixes
  • This PR contains all the relevant tests
  • This PR creates a breaking change

Please describe the differences between the current and new behavior

This feature simplifies datx-jsonapi-angular setup

@fvoska fvoska force-pushed the feat/refactor-angular-datx-setup branch 2 times, most recently from 7c5782f to 16efdff Compare April 21, 2023 08:08
@fvoska fvoska force-pushed the feat/refactor-angular-datx-setup branch from 16efdff to e0be13a Compare April 21, 2023 08:10
@fvoska fvoska marked this pull request as ready for review April 21, 2023 08:35
@fvoska fvoska requested a review from danipavic April 21, 2023 08:35
danipavic
danipavic approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@danipavic danipavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fvoska fvoska changed the title feat: refactor angualr datx setup feat: refactor Angular setup Apr 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fvoska fvoska changed the title feat: refactor Angular setup feat(jsonapi-angular)!: refactor Angular setup Apr 21, 2023
@fvoska fvoska merged commit 3986d42 into master Apr 21, 2023
11 checks passed
@fvoska fvoska deleted the feat/refactor-angular-datx-setup branch April 21, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danipavic danipavic danipavic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fvoska @danipavic