Init codemod package #1171
Init codemod package #1171
Conversation
| fs.copyFileSync('./README.md', './dist/README.md'); | ||
| fs.copyFileSync('./LICENSE', './dist/LICENSE'); | ||
|
|
||
| fs.rmdirSync('./dist/transforms/__testfixtures__', { recursive: true }); |
There was a problem hiding this comment.
Should this be handled in .npmignore instead?
There was a problem hiding this comment.
What should I add to it?
Should I copy .npmignore to dist folder then?
Because we are doing release from dist folder.
We are not doing this in any other package.
There was a problem hiding this comment.
yeah, I think it should be in the folder that is beeing published. By default, npm is taking gitignore if npmignore doesn't exist, so that's why we didn't really need it until now.
There was a problem hiding this comment.
Is this what you meant?
Honestly, I don't like this setup.
It would make sense if we publish from the root and we don't want to publish some dev stuff.
We need to rethink publishing process and make a setup that would allow publishing form the package root folder, otherwise it might be confusing.
There was a problem hiding this comment.
https://www.npmjs.com/package/clean-package this tool can clean the root package.json form all the nonsense before publish and revert it back.
Then we will be able to publish form the root folder and in that case .npmignore would make complete sense.
There was a problem hiding this comment.
Ok, leave it as is for now
|
Kudos, SonarCloud Quality Gate passed!
|
Please select all that apply:
Please describe the differences between the current and new behavior
Codemods for migrating form datx v1 to v2