Add custom badges/shields on doc pages #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 29, 2020 13:42
gabriel-glo
requested review from
dingo-d,
kmaric69,
iruzevic,
tihomirselak,
MetarDev and
volfkarlo
MetarDev
reviewed
Feb 29, 2020
|
|
||
| Helper is located in the [eightshift-libs](https://github.com/infinum/eightshift-libs/blob/935e7bc777094d7518950316a45061f7675cf7ed/src/blocks/class-blocks.php#L295) library. | ||
| Locate and return template part with passed attributes for a block. |
There was a problem hiding this comment.
Intentionally removed link or?
There was a problem hiding this comment.
As I wrote in PR description:
Removed links to libs in doc pages (we have badges now)
There is no need to link to the repo two times in short period time
Comment on lines
+75
to
+79
| article p img { | ||
| margin-left: 0; | ||
| display: inline-block; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is really unspecific, do badges have some kind of selectors on them you can use instead?
There was a problem hiding this comment.
There are no options to select specific images.
This won't break the layout of the image, it will just push it to the left.
* master: updating PR fixes Updating docs Updating docs Updating docs updating docs Updating docs adding block-attributes-override filter
dingo-d
approved these changes
Mar 1, 2020
kmaric69
previously approved these changes
Mar 2, 2020
dingo-d
previously approved these changes
Mar 2, 2020
added 2 commits
March 5, 2020 20:04
* master: updating readme updating PRs updating docs updating docs fix typo Updating columns, helpers docs Updating columns Adding error logger helper Updating advance part Updating advance part Updating post type and rest fields Add layout overrides for flex containers Update the layout of footer links to the repos Updating docs Updating docs Add prefixed CSS Update footer layout Layout change in Get started cards
iruzevic
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some image styles so badges look good and can be stacked in a single row
Add two versions of custom badges for showing where the examples are located (libs or frontend libs)
Removed links to libs in doc pages (we have badges now)
Removed some trailing whitespaces
Add one more badge image for Eightshift Boilerplate
Add doc badges to the rest of the chapters
Add short explanation of the
Shrtcodeclass