Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for filterComponentOptions #77

Merged
merged 23 commits into from
Mar 22, 2021
Merged

Add documentation for filterComponentOptions #77

merged 23 commits into from
Mar 22, 2021

Conversation

goranalkovic-infinum
Copy link
Contributor

@goranalkovic-infinum goranalkovic-infinum commented Feb 17, 2021 •
edited by iruzevic
Loading

I have updated the chapter with the new documentation

@goranalkovic-infinum goranalkovic-infinum requested a review from a team February 17, 2021 09:49
@goranalkovic-infinum goranalkovic-infinum self-assigned this Feb 17, 2021
@goranalkovic-infinum goranalkovic-infinum mentioned this pull request Feb 17, 2021
Closed
iruzevic
iruzevic requested changes Feb 17, 2021
View reviewed changes
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
website/docs/basics/blocks-component-in-block.md Outdated Show resolved Hide resolved
kmaric69
kmaric69 previously approved these changes Feb 17, 2021
View reviewed changes
iruzevic
iruzevic previously approved these changes Feb 23, 2021
View reviewed changes
MetarDev
MetarDev previously approved these changes Feb 23, 2021
View reviewed changes
@dingo-d dingo-d added this to the 5.0.1 milestone Mar 3, 2021
@iruzevic iruzevic dismissed stale reviews from MetarDev, kmaric69, and themself via fcb0485 March 21, 2021 22:32
@iruzevic iruzevic requested review from a team, MetarDev, iruzevic and kmaric69 March 21, 2021 22:33
@iruzevic iruzevic linked an issue Mar 21, 2021 that may be closed by this pull request
[FEATURE] Explain how to override options to show from the parent component #80
Closed
MetarDev
MetarDev previously approved these changes Mar 22, 2021
View reviewed changes
@iruzevic iruzevic linked an issue Mar 22, 2021 that may be closed by this pull request
[FEATURE] Explain how to use props helper to limit attributes passed in the component #81
Closed
iruzevic and others added 4 commits March 22, 2021 11:16
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
b163956 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
fd035c7 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
1aedf80 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
e9d616a 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
dingo-d
dingo-d requested changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments and suggestions

iruzevic and others added 4 commits March 22, 2021 11:25
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
bfab9f7 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
f1ec8c0 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Update website/docs/basics/blocks-component-in-block.md
3a892a7 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic @dingo-d
Apply suggestions from code review
b3ad8bd 
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
@iruzevic
Copy link
Member

I have accepted all

@iruzevic iruzevic requested a review from dingo-d March 22, 2021 10:27
@iruzevic iruzevic merged commit e43ccdf into develop Mar 22, 2021
@iruzevic iruzevic deleted the feature/filter-options-helper-doc branch March 22, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingo-d dingo-d dingo-d approved these changes

@iruzevic iruzevic Awaiting requested review from iruzevic

@kmaric69 kmaric69 Awaiting requested review from kmaric69

@MetarDev MetarDev Awaiting requested review from MetarDev

@iobrado iobrado Awaiting requested review from iobrado

Assignees

@iruzevic iruzevic

Labels
None yet
Projects
None yet
Milestone
Future release
6 participants
@goranalkovic-infinum @iruzevic @dingo-d @kmaric69 @iobrado @MetarDev