Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): fix parser not including nested relationships #19

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix(parser): fix parser not including nested relationships #19

merged 3 commits into from
Feb 16, 2023

Conversation

nicobritos
Copy link
Contributor

No description provided.

@nicobritos
Copy link
Contributor Author

Doesn't remove relationships if they are not marked in the included string when calling Japx.decode. This makes sense as we (devs) are making the API calls, and responses are expected to be parsed in they totallity. This solves the issue that array relationships contains null items.

@nicobritos nicobritos mentioned this pull request Dec 15, 2021
Closed
@itsJoKr
Merge branch 'master' into fix-null-not-included
26a1de0 
# Conflicts:
#	example/pubspec.lock
#	lib/src/parser.dart
#	pubspec.lock
#	test/test_data.dart
@itsJoKr
Fix conflicts
ad94569
@itsJoKr itsJoKr merged commit 5c2b97b into infinum:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicobritos @itsJoKr