[Merged by Bors] - Use file name for the external commands (fixes #889)

[avinassh]

Ran into this issue myself, I thought I'd send a patch. Here is the new output now:

$ cargo run

Fluvio command-line interface

fluvio-cli [FLAGS] [OPTIONS] <SUBCOMMAND>

FLAGS:
        --tls                   Enable TLS
        --enable-client-cert    TLS: use client cert
    -h, --help                  Prints help information

OPTIONS:
    -c, --cluster <host:port>          Address of cluster
        --domain <domain>              Required if client cert is used
        --ca-cert <ca-cert>
            Path to TLS ca cert, required when client cert is enabled

        --client-cert <client-cert>    Path to TLS client certificate
        --client-key <client-key>      Path to TLS client private key
    -P, --profile <profile>

SUBCOMMANDS:
    consume         Read messages from a topic/partition
    produce         Write messages to a topic/partition
    topic           Manage and view Topics
    partition       Manage and view Partitions
    profile         Manage Profiles, which describe linked clusters
    cluster         Install or uninstall Fluvio clusters
    install         Install Fluvio plugins
    update          Update the Fluvio CLI
    version         Print Fluvio version information
    fluvio-cloud    Cloud Operations
    help            Prints this message or the help of the given
                    subcommand(s)

[nicholastmosher]

Thanks for the PR @avinassh, it's greatly appreciated!

External subcommands have filenames with the prefix fluvio-, such as fluvio-cloud, but the name of the subcommand that should show up in the help menu should be everything after the prefix. In the fluivo-cloud example, cloud should be displayed in help. I think str::strip_prefix("fluvio-") would work nicely here.

One nit: could you use a match statement instead of if-let/else?

Thanks!

[avinassh]

External subcommands have filenames with the prefix fluvio-, such as fluvio-cloud, but the name of the subcommand that should show up in the help menu should be everything after the prefix

Is this always guaranteed and I can call unwrap on str::strip_prefix OR should I handle the None case as well?

Also, I noticed one more thing:

$ cargo run -- cloud --help

USAGE:
    fluvio-cloud <SUBCOMMAND>

// snipped

I believe this needs to be changed as well, but I am not able to find where exactly this extension is located in Github org

[nicholastmosher]

I think the representation in the help menu is a different issue than this. Fixing it would probably require editing the help menu template used by structopt/clap. Also just FYI, fluvio-cloud currently belongs to a private repo which is why you wouldn't have found it

[avinassh]

I think the representation in the help menu is a different issue than this.

yeah, actually you are right. btw do you could tell me about the other thing:

Is this always guaranteed and I can call unwrap on str::strip_prefix OR should I handle the None case as well?

[nicholastmosher]

@avinassh in the current implementation, it should be guaranteed, yes: https://github.com/infinyon/fluvio/blob/master/src/cli/src/install/mod.rs#L43-L58

I'd say let's move forward using that unwrap, and if anything changes such that this would actually panic, we'll consider those changes a bug and we'll update accordingly at that time.

[avinassh]

Nice! I have updated the PR.

$ cargo run -- --help

// snipped

SUBCOMMANDS:
    consume      Read messages from a topic/partition
    produce      Write messages to a topic/partition
    topic        Manage and view Topics
    partition    Manage and view Partitions
    profile      Manage Profiles, which describe linked clusters
    cluster      Install or uninstall Fluvio clusters
    install      Install Fluvio plugins
    update       Update the Fluvio CLI
    version      Print Fluvio version information
    cloud        Cloud Operations
    help         Prints this message or the help of the given subcommand(s)

[nicholastmosher]

Looks great! Thanks @avinassh!

[nicholastmosher]

bors r+

[bors]

Pull request successfully merged into master.

Build succeeded:

• Clippy (ubuntu-latest)
• Doc tests (macos-latest)
• Doc tests (ubuntu-latest)
• Done
• Kubernetes cluster test (infinyon-ubuntu-bionic, stable)
• Local cluster test (infinyon-ubuntu-bionic, stable)
• Rustfmt (ubuntu-latest)
• Unit tests (macos-latest)
• Unit tests (ubuntu-latest)