Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add 'fluvio diagnostics' for collecting debug information #1671

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Add 'fluvio diagnostics' for collecting debug information #1671

wants to merge 8 commits into from

Conversation

nicholastmosher
Copy link
Contributor

Closes #1667 and #1215

Adds fluvio diagnostics subcommand which will produce a zip file, diagnostics-YYYY-MM-DD-hh-mm-ss.zip. This file contains:

  • Logs for any SC or SPU, local or kubernetes
  • Kubernetes metadata, including all Fluvio pods/services/statefulsets, and CRD's spu/spg/partition/topic
  • Fluvio admin metadata, topic/partition/spu/spg

@sehz
Copy link
Contributor

sehz commented Sep 21, 2021 •
edited
Loading

I noticed that it is using zip format. This should be in .gz format as they are unix standard. They should be in the a single directory.

Unzipping `unzip ~/fluvio/diagnostics-2021-09-21-20-06-58.zip 
Archive:  /home/ubuntu/fluvio/diagnostics-2021-09-21-20-06-58.zip
replace spu_log_5003.log? [y]es, [n]o, [A]ll, [N]one, [r]ename:

So this overwrites existing file

sehz
sehz requested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add to change log.
  • need to add k8 PVC objects

crates/fluvio-cluster/src/cli/diagnostics.rs Outdated Show resolved Hide resolved
crates/fluvio-cluster/src/cli/error.rs Outdated Show resolved Hide resolved
@nicholastmosher
Copy link
Contributor Author

@sehz this should be ready to go. Now uses .tar.gz instead of .zip, and extracts into a ./diagnostics/ directory.

sehz
sehz approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! this will make it easier to collect debugging info fluvio

@sehz
Copy link
Contributor

sehz commented Sep 22, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2021
@nicholastmosher
Add 'fluvio diagnostics' for collecting debug information (#1671)
ad48a07 
Closes #1667 and #1215

Adds `fluvio diagnostics` subcommand which will produce a zip file, `diagnostics-YYYY-MM-DD-hh-mm-ss.zip`. This file contains:

- Logs for any SC or SPU, local or kubernetes
- Kubernetes metadata, including all Fluvio pods/services/statefulsets, and CRD's spu/spg/partition/topic
- Fluvio admin metadata, topic/partition/spu/spg
@bors
Copy link

bors bot commented Sep 22, 2021

Build failed:

@sehz
Copy link
Contributor

sehz commented Sep 22, 2021

clippy failures

@nicholastmosher
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2021
@nicholastmosher
Add 'fluvio diagnostics' for collecting debug information (#1671)
251d995 
Closes #1667 and #1215

Adds `fluvio diagnostics` subcommand which will produce a zip file, `diagnostics-YYYY-MM-DD-hh-mm-ss.zip`. This file contains:

- Logs for any SC or SPU, local or kubernetes
- Kubernetes metadata, including all Fluvio pods/services/statefulsets, and CRD's spu/spg/partition/topic
- Fluvio admin metadata, topic/partition/spu/spg
@bors
Copy link

bors bot commented Sep 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add 'fluvio diagnostics' for collecting debug information [Merged by Bors] - Add 'fluvio diagnostics' for collecting debug information Sep 22, 2021
@bors bors bot closed this Sep 22, 2021
@nicholastmosher nicholastmosher deleted the diagnostics branch September 22, 2021 17:17
@tjtelan tjtelan linked an issue Sep 23, 2021 that may be closed by this pull request
Add fluvio diagnostics for collecting useful debugging information #1215
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster support logs Add fluvio diagnostics for collecting useful debugging information
2 participants
@nicholastmosher @sehz