Add callbacks on #create and #switch! #307
Conversation
cbeer
force-pushed
the
callbacks
branch
2 times, most recently
from
e367d85
to
43b9075
Compare
| @@ -80,10 +85,12 @@ def drop(tenant) | |||
| # @param {String} tenant name | |||
| # | |||
| def switch!(tenant = nil) | |||
| return reset if tenant.nil? | |||
| run_callbacks :switch do | |||
There was a problem hiding this comment.
wouldn't you want both switch! and switch (below) ?
There was a problem hiding this comment.
Hm. #switch uses #switch! internally, so I think #switch! is sufficient, unless we want to distinguish callbacks for #switch vs #switch!. I'm not sure it'd make a difference to what I'm trying to do, though. Thoughts?
Note, though, a call to #switch will run the callbacks twice, once when it switches into the new tenant and once when it reverts back to the previous one. This behavior is useful for my purposes, but could be unexpected without knowing the internals of #switch.
There was a problem hiding this comment.
I'm ok with it being called twice on switch, just wasn't sure if this is what you'd expect.
|
Would love to see this PR merged, and it looks like there are no objections or suggested changes. Anything holding this up? @bradrobertson ? |
|
Thanks, @bradrobertson! When do you think the next release (1.2.0?) might be cut? |
One additional use case we have for multitenant applications is being able to switch additional connections to external resources (say, a search index connection or a storage bucket). We're currently triggering this logic through some hooks in the controller and/or job, but pushing it down into apartment would give us more confidence that everything is getting appropriately switched.