Fix logs query error #4861
Merged
Fix logs query error #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthesorceror
approved these changes
Dec 3, 2018
OfTheDelmer
force-pushed
the
fix/log-query-error
branch
from
cb38aed
to
4be2020
Compare
OfTheDelmer
added a commit
that referenced
this pull request
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4851
Briefly describe your proposed changes:
Add quotes in meta query building that checks for syslog measurement
What was the problem?
Missing quotes in a query caused an unhandled error that made the log viewer appear to be stuck querying when it was not.
What was the solution?
Update the query building to have quotes and the thunk action to handle the error with a status update so the log viewer doesn't appear to be stuck loading.