feat: add support for string comparison operators #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `x < y`, `x <= y`, `x > y`, and `x >= y` were rejected when x and y were both strings. Now they are accepted, and they operate on lexicographic comparison like any other language.
aanthony1243
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
I can't think of any reason this wasn't in there except that there are plans to support a full complement of string functions and maybe we we're holding out for that. we might want to get Nathaniel to ok this but it's not a huge change and easy to revert if he had a different plan
nathanielc
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
x < y,x <= y,x > y, andx >= ywere rejected whenx and y were both strings. Now they are accepted, and they operate on
lexicographic comparison like any other language.