Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): minor improvements and fixes #3242

Closed
wants to merge 11 commits into from

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Oct 7, 2020

This PR contains minor improvement and fixes to 'sql` package:

  • return error with codes.Invalid instead of codes.Internal from translationFunc for unsupported types
  • fix TUint mapping for MySQL from BIGINT to BIGINT UNSIGNED
  • move invariant code out of loop in to.go: CreateInsertComponents(), remove unused map labels
  • move flux->db type map out of translationFunc and use direct type comparison instead of string representation
  • mssql/Azure:

Done checklist

  • Test cases written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants