Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(libflux): document fluxcore::semantic::bootsrap module #3694

Merged
merged 4 commits into from
May 19, 2021

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented May 7, 2021

Removes #![allow(missing_docs)].

The meaning of this module was not entirely clear to me. Can we say more about what "bootstrap" means here? 🤔

@pierwill pierwill requested review from a team and jsternberg and removed request for a team May 7, 2021 16:48
@pierwill
Copy link
Contributor Author

pierwill commented May 7, 2021

Example: The flux crate calls bootstrap::infer_stdlib(). Does this make sense with my description of the module as "Flux start-up"?

@pierwill pierwill force-pushed the docs-libflux-semantic-bootstrap branch from 348c9c9 to cdb1595 Compare May 18, 2021 19:01
@jsternberg
Copy link
Contributor

One caveat:

Example: The flux crate calls bootstrap::infer_stdlib(). Does this make sense with my description of the module as "Flux start-up"?

Bootstrap happens at compile time and doesn't happen at runtime. The bootstrap infers the types and is used to embed the results into the resulting library so they can be accessed more quickly.

@pierwill pierwill force-pushed the docs-libflux-semantic-bootstrap branch from cdb1595 to dfbd20b Compare May 19, 2021 15:59
@pierwill pierwill merged commit 4ef5d9b into master May 19, 2021
@pierwill pierwill deleted the docs-libflux-semantic-bootstrap branch May 19, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants