Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(influxdb-enterprise): allow to customize meta service properties #468

Merged
merged 4 commits into from
May 5, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented May 2, 2022

This PR allows customizing influxdb-enterprise meta service the same way as it is already possible for the data service. I.e.
meta.service.type can change the k8s service type and a few other other attributes can be specified when using LoadBalancer service type.

Additionally meta.service.nodePort and data.service.nodePort can further specify fixed (main) HTTP node ports when NodePort service type is used.

These changes make it easy for me to customize influxdb-enterprise helm chart locally for development, by changing data/meta services to NodePort and assigning a specific nodePort.

helm upgrade --install influxdb influxdata/influxdb-enterprise --namespace default \
  --set-string envFromSecret=influxdb-license \
  --set-string data.service.type=NodePort \
  --set-string meta.service.type=NodePort \
  --set data.service.nodePort=30086 \
  --set meta.service.nodePort=30091  

@sranka sranka changed the title feat(influxdb-enterprise): allow to specify meta service properties feat(influxdb-enterprise): allow to customize meta service properties May 2, 2022
@sranka sranka requested a review from alespour May 2, 2022 14:14
@sranka sranka marked this pull request as ready for review May 2, 2022 14:14
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sranka sranka requested a review from tomklapka May 4, 2022 04:30
@sranka sranka merged commit 3219dd5 into master May 5, 2022
@sranka sranka deleted the influxdb-enterpise/meta_svc_type branch May 5, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants