Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor request execution to use Execute() on request objects #55

Closed
danxmoran opened this issue Apr 30, 2021 · 0 comments · Fixed by #56
Closed

Refactor request execution to use Execute() on request objects #55

danxmoran opened this issue Apr 30, 2021 · 0 comments · Fixed by #56
Assignees

Comments

@danxmoran
Copy link
Contributor

Our codegen supports executing constructed requests in one of two ways:

  1. Clients have a <OperationId>Execute method per operation
  2. Requests have an Execute method that delegates to the appropriate ^^^ method under-the-hood

Initial commands have used style 1, but after seeing style 2 used in #52 and #53 I think it's a better approach, because:

  • It allows for building and executing requests in a single statement, reducing noise
  • In the future, it reduces the amount of context we need to pass around in order to extend & execute partially-constructed requests

Refactor the few commands that are already in place to use this style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant