-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bucket schema management commands #52
Conversation
6495cdf
to
c16c348
Compare
0d4a6dc
to
4cfb5de
Compare
c16c348
to
0b6cf82
Compare
f0ac72e
to
01dd763
Compare
0b6cf82
to
72ffab2
Compare
01dd763
to
571b1de
Compare
dfa8b54
to
178c072
Compare
"github.com/influxdata/influx-cli/v2/internal" | ||
"github.com/urfave/cli/v2" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move our existing global flag var
s out of main.go
and into this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could move the variables to this package and leave the bindings in main
– that keeps with your mantra of leaving urfave
logic in cmd
571b1de
to
bf5a85c
Compare
95ae196
to
a119287
Compare
NOTE: I've modified the script to reference the updated spec via https://github.com/influxdata/openapi/tree/sgc/issues/9672 to validate this PR via CI. I've opened influxdata/openapi#34 for review and will remove the last commit when it merges to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can rebase against main
Not sure what happened, but however |
58dfb3d
to
26f16ef
Compare
Also renames and regenerates based on updated ".gen.go" convention
3a6e96c
to
d722981
Compare
205fb22
to
99ecea1
Compare
Hi @danxmoran – let me know if there are still any outstanding questions you have. I've added a number of unit tests for all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @stuartcarnie! Exciting to see a cloud-focused feature land early.
This PR extends the tool with commands to manage explicit schema buckets per #51.
Changes include:
bucket create
command to allow specifying a schema-type of eitherimplicit
(default) orexplicit
bucket list
command to show the schemaType property as a new column,Schema Type
bucket-schema
command, with the following sub-commands:create
to create a new measurement schema for an existingexplicit
schema bucket;update
to add new columns to an existing measurement schema; andlist
to find and print information about existing measurement schemas.