Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not track SQL SCHEMA queries #61

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

ChrisBr
Copy link
Collaborator

@ChrisBr ChrisBr commented Dec 12, 2018

No description provided.

@dmke
Copy link
Collaborator

dmke commented Dec 12, 2018

Makes sense. Can you run rake rubocop:auto_correct and update your last commit?

because they're not interesting for analysis.
@ChrisBr ChrisBr force-pushed the sql_improvements branch 2 times, most recently from d939aad to 672a5db Compare December 12, 2018 12:15
@dmke dmke merged commit 085e245 into influxdata:master Dec 12, 2018
@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Dec 12, 2018

Thanks for merging, I just saw that this was now for master 😢 Sorry... Should I create a new one targeting beta or do you cherry pick? (same for #62)

@dmke
Copy link
Collaborator

dmke commented Dec 12, 2018

No, master is OK, I'll abandon the 1.0-beta branch soon.

@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Dec 12, 2018

Ok, cool! Thanks 👍 Do you plan to release another beta?

@dmke
Copy link
Collaborator

dmke commented Dec 12, 2018

Yes. I'm still keen on #56 to be in at least one beta release, but last week was a bit stressful... This week I'm still busy with different things, but starting next week I'm on vacation and I can concentrate on finishing this (hopefully, that is :-D).

@ChrisBr
Copy link
Collaborator Author

ChrisBr commented Dec 12, 2018

Ok, cool! Enjoy your vacation 👍 : I will also be on vacation starting Friday but will be at the beach, so no more noise from my side 😄 🏖️

Btw: We already have beta 2 running here: https://metrics.opensuse.org/d/Gpp3B1Pik/package-show-dashboard?orgId=1 and already helped us to spot some bottlenecks 👍

@ChrisBr ChrisBr deleted the sql_improvements branch January 13, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants