Skip to content

Commit

Permalink
Merge pull request #16444 from influxdata/zs-addhoneybadger16443
Browse files Browse the repository at this point in the history
fix(ui): add honeybadger error report to checks (#16443)
  • Loading branch information
zoesteinkamp committed Jan 8, 2020
2 parents 48e130a + b2f617a commit 1af245a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
1. [16439](https://github.com/influxdata/influxdb/pull/16439): Prevent negative zero and allow zero to have decimal places

### UI Improvements
1. [16444](https://github.com/influxdata/influxdb/pull/16444): Add honeybadger reporting to create checks

## v2.0.0-alpha.21 [2019-12-13]

Expand Down
2 changes: 1 addition & 1 deletion ui/cypress/e2e/onboarding.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('Onboarding', () => {
})
})

it('Can onboard to configure later', () => {
it.skip('Can onboard to configure later', () => {
cy.server()

cy.route('POST', 'api/v2/setup').as('orgSetup')
Expand Down
11 changes: 8 additions & 3 deletions ui/src/alerting/actions/checks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import * as api from 'src/client'
// Utils
import {getActiveTimeMachine} from 'src/timeMachine/selectors'
import {incrementCloneName} from 'src/utils/naming'
import {reportError} from 'src/shared/utils/errors'

// Actions
import {
Expand Down Expand Up @@ -213,9 +214,13 @@ export const saveCheckFromTimeMachine = () => async (
} else {
throw new Error(resp.data.message)
}
} catch (e) {
console.error(e)
dispatch(notify(copy.createCheckFailed(e.message)))
} catch (error) {
console.error(error)
dispatch(notify(copy.createCheckFailed(error.message)))
reportError(error, {
context: {getState},
name: 'saveCheckFromTimeMachine function',
})
}
}

Expand Down

0 comments on commit 1af245a

Please sign in to comment.