Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add honeybadger error report to checks (#16443) #16444

Merged
merged 4 commits into from
Jan 8, 2020
Merged

fix(ui): add honeybadger error report to checks (#16443) #16444

merged 4 commits into from
Jan 8, 2020

Conversation

zoesteinkamp
Copy link
Contributor

Closes #16443

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

ebb-tide
ebb-tide approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, feel free to merge after addressing it

ui/src/alerting/actions/checks.ts Show resolved Hide resolved
@zoesteinkamp zoesteinkamp merged commit 1af245a into master Jan 8, 2020
@zoesteinkamp zoesteinkamp deleted the zs-addhoneybadger16443 branch January 8, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add honeybadger notification to failed check create
2 participants
@zoesteinkamp @ebb-tide