Skip to content

Commit

Permalink
Remove redaction logic from parseCredentials.
Browse files Browse the repository at this point in the history
We now redact the credentials in the logger, so the function implemented
by the deleted lines now seems redudndant.

Signed-off-by: Jon Seymour <jon@wildducktheories.com>
  • Loading branch information
jonseymour committed Aug 18, 2015
1 parent 2805c4a commit 1d5ff55
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions services/httpd/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,6 @@ func parseCredentials(r *http.Request) (string, string, error) {
q := r.URL.Query()

if u, p := q.Get("u"), q.Get("p"); u != "" && p != "" {
q.Set("p", "[REDACTED]")
r.URL.RawQuery = q.Encode()
return u, p, nil
}
if u, p, ok := r.BasicAuth(); ok {
Expand Down

0 comments on commit 1d5ff55

Please sign in to comment.