Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store number of fields in encoded data #1636

Closed
otoolep opened this issue Feb 18, 2015 · 3 comments
Closed

Don't store number of fields in encoded data #1636

otoolep opened this issue Feb 18, 2015 · 3 comments
Assignees

Comments

@otoolep
Copy link
Contributor

otoolep commented Feb 18, 2015

It's not clear that the code needs to store the number of fields in the encoded field-values. Instead, when decoding, the system could just iterate over the slice. This would save a byte per encoded field-values.

@benbjohnson -- any reason this wouldn't work?

cc @pauldix

@otoolep
Copy link
Contributor Author

otoolep commented Feb 24, 2015

Fixed.

@otoolep otoolep closed this as completed Feb 24, 2015
@tisba
Copy link

tisba commented Mar 24, 2015

@otoolep The CHANGELOG.md states that this is a breaking change. Will there be a migration path from 0.8.x?

@pauldix
Copy link
Member

pauldix commented Mar 24, 2015

@tisba there will be a migration path. See http://influxdb.com/docs/v0.8/advanced_topics/schema_design.html#migration-to-0.9.0 for details on how to structure things in 0.8 to make the migration to 0.9 clean. We haven't written the migration tool yet, but will do so before the full 0.9.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants