-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.10.0] DROP RETENTION POLICY does not clean up data. #5653
Comments
I wonder, once fixed, is it going to cleanup/free the data from RPs that have been dropped in the past/before fix? |
@zstyblik unfortunately not. |
@e-dard :-\ Is there any trick how to achieve that? How about backup and restore? Could it do the trick? |
@zstyblik doing "cleanup" automatically can be problematic, and lead to the loss of data if there are bugs etc. My suggestion would be to manually check for any retention policy you don't want and remove the data that way. Retention policies are stored as follows:
In this case (aside from the If you dropped the |
@e-dard I see. Alright then, I'll keep it in mind. Although, with other fixes related to TSM, backup & restore might be worth of trying first. Thanks. |
Fixes #5653 and #5394. Previously dropping retention policies did not propogate to local TSDB shards. Instead, the retention policiess would just be removed from the Meta Store. This PR adds ensures that data associated with retention policies is removed, when the retention policy is dropped. Also, it cleans up a couple of other methods in `tsdb`, including the requirement to provide (redundant) shardIDs when deleting databases.
Fixes #5653 and #5394. Previously dropping retention policies did not propogate to local TSDB shards. Instead, the retention policiess would just be removed from the Meta Store. This PR adds ensures that data associated with retention policies is removed, when the retention policy is dropped. Also, it cleans up a couple of other methods in `tsdb`, including the requirement to provide (redundant) shardIDs when deleting databases.
It's not implemented on the
tsdb.Store
, so data is not cleaned up after the retention policy is removed.The text was updated successfully, but these errors were encountered: