Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for hostname resolution #5670

Closed
corylanou opened this issue Feb 13, 2016 · 0 comments
Closed

Change logic for hostname resolution #5670

corylanou opened this issue Feb 13, 2016 · 0 comments

Comments

@corylanou
Copy link
Contributor

We need to have a consistent way of determining hostname for all of our services when they start up. Currently you can specify the hostname in the config, but when you specify a bind address with just a port, it doesn't pick up that host name in all services.

Also, we should bind to 0.0.0.0 instead of localhost or 127.0.0.1 if no hostname is specified.

jwilder added a commit that referenced this issue Feb 17, 2016
This fixes several issues related to the bind address and hostname:
* Allows bind addresses where a hostname or IP is not specified to
work correct and bind to all interfaces by default.
* Fixes the top-level "hostname" config option to allow overridding
all bind address hostnames.  This allows a node to advertise a different
hostname than what is defined in the bind address setting.
* Adds the -hostname command-line option back to allow specifing
both -join and -hostname as command-line flags.
* Enforces a configuration precedence and overriding ability defined
as config file is overridden by env vars which are overriden by command-line
flags.

Fixes #5670 #5671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants