Add option to hint MADV_WILLNEED to kernel #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a configuration option that can be used to inform the kernel that we intent to page in much of the TSM files. This madvise value has been problematic in the past when its been set, so this option defaults to off. It may be useful to some users with slow disks.
ghost
assigned 
zeebo
approved these changes
Aug 3, 2018
| // that we will be reading the index section, but that's not been | ||
| // implemented as yet. | ||
| if m.mmapWillNeed { | ||
| if err := madviseWillNeed(m.b); err != nil { |
There was a problem hiding this comment.
munmap here? i guess this comment applies to a bunch of spots in this function lol. in addition to file handle resources. rename has the same problem. seems big enough for another ticket/bug maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10117.
This PR adds a new configuration option -
tsm-use-madv-willneed/INFLUXDB_DATA_TSM_USE_MADV_WILLNEED, which, when true, will hint to the kernel that we plan on sequentially reading TSM files.This option defaults to false because we have had some issues in the past with certain kernels/operating systems. However, it may be useful to some users with slow disks.