Ensure orhpaned series cleaned up with shard drop #10212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where series could be left in the
inmem
index, when they should have been removed.It could be triggered as follows:
SHOW
query such asSHOW TAG KEYS
;SHOW
query such asSHOW TAG KEYS
;This manifests itself because the series were removed from the series file, but not from the
inmem
index. If the server was restarted the issue would resolve itself.Commit f52de2d ensures that the series are removed from the
inmem
index if they're the last occurence of those series in the index.TODO: whilst doing this work, it's become apparent that dropping shards with the
inmem
index is particularly racy, when one considers concurrent writes of the same series. I will add a ticket to track that.