fix(tasks): clear existing task schedule when changing types #12793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
fix/switching-cron-every-on-tasks
branch
from
7c22be9
to
e03c97b
Compare
AlirieGray
force-pushed
the
fix/switching-cron-every-on-tasks
branch
4 times, most recently
from
30a6c7b
to
909c3ec
Compare
121watts
approved these changes
Mar 20, 2019
ui/src/tasks/reducers/tasks.test.ts
Outdated
| import {TaskSchedule} from 'src/utils/taskOptionsToFluxScript' | ||
|
|
||
| describe('tasksReducer', () => { | ||
| it('clears the cron property from the task options when interval is selected', () => { |
There was a problem hiding this comment.
these tests could have a another describe for the action these reducers are responding to. i.e."
describe('tasksReducer', () => {
describe('setTaskOption', () => {
... setTaskOption tests here
})
})
AlirieGray
force-pushed
the
fix/switching-cron-every-on-tasks
branch
from
909c3ec
to
5bf72b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12690
This PR fixes an issue where switching between the "cron" and "interval" schedule types would cause an error when creating or editing a task. Now the reducer for setting a task option will clear the previous task schedule type when a new one is added.
The v2 folders for task actions and reducers are also removed in this PR.