feat(dashboards): add overlay to create dashboard from template #13078
Conversation
AlirieGray
force-pushed
the
templates/import-resource-from-template-overlay
branch
from
35b8625
to
6cde9ac
Compare
| router, | ||
| params: {orgID}, | ||
| } = this.props | ||
| router.push(`/orgs/${orgID}/dashboards/templates`) |
There was a problem hiding this comment.
this route url should have something in it to indicate that its import /orgs/${orgID}/dashboards/import/template would be my go to.
| title={_.get(selectedTemplateSummary, 'meta.name')} | ||
| /> | ||
| <Panel.Body> | ||
| {/* TODO: Add Template description */} |
There was a problem hiding this comment.
Please do not leave comments in JSX
ui/src/dashboards/actions/index.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| // Libraries | |||
| import {Dispatch} from 'redux' | |||
| import _ from 'lodash' | |||
There was a problem hiding this comment.
Do we need lodash here? Nothing else added seems to use it.
| </ResponsiveGridSizer> | ||
| </OrgTemplateFetcher> | ||
| {!selectedTemplateSummary && ( | ||
| <Panel className="import-template-overlay--empty"> |
There was a problem hiding this comment.
Could we extract the empty state? There is a lot going on in this render function.
| @@ -117,6 +118,11 @@ class Dashboards extends PureComponent<Props, State> { | |||
| router.push(`/organizations/${params.orgID}/dashboards/import`) | |||
| } | |||
|
|
|||
| private summonImportFromTemplateOverlay = (): void => { | |||
| const {router, params} = this.props | |||
| router.push(`/organizations/${params.orgID}/dashboards/templates`) | |||
There was a problem hiding this comment.
Same comment about the route.
| <Dropdown.Item id={newOption} key={newOption} value={newOption}> | ||
| {newOption} | ||
| </Dropdown.Item>, | ||
| <Dropdown.Item id={importOption} key={importOption} value={importOption}> | ||
| {importOption} | ||
| </Dropdown.Item>, | ||
| ] | ||
|
|
||
| if (!!this.props.onSelectTemplate) { |
There was a problem hiding this comment.
seems odd that the existence of a handler is determining whether to render this.
There was a problem hiding this comment.
would you recommend a boolean prop instead?
There was a problem hiding this comment.
yeah that seems more informative
AlirieGray
force-pushed
the
templates/import-resource-from-template-overlay
branch
5 times, most recently
from
44849b1
to
874bc16
Compare
AlirieGray
force-pushed
the
templates/import-resource-from-template-overlay
branch
3 times, most recently
from
965a598
to
c124273
Compare
AlirieGray
force-pushed
the
templates/import-resource-from-template-overlay
branch
from
c124273
to
d10d216
Compare
Closes #12913
This PR adds an overlay to create a new dashboard from a template.