Update query builder metaqueries #13678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, slight changes in the form of a Flux metaquery can have drastic performance implications. To solve this issue, the Flux language provides helper metaquery functions such as `v1.tagKeys` and `v1.tagValues` which are guaranteed to be as fast as possible. In #12791, we switched away from using the `v1.tagKeys` and `v1.tagValues` functions in the query builder to their underlying Flux implementations in order to implement a UI feature. While the new metaqueries used in the query builder were still optimized at the time, the Flux language has since changed and this is no longer the case. In addition, the metaqueries in the UI no longer hit the same code-path in Flux which has exposed a logic bug in the queries. So when executed, the metaqueries return the following error: schema collision detected: column ""_value"" is both of type float and int This PR updates the metaqueries used in the query builder to their [currently optimized form][0]. The long term solution is to address [this][1] issue and then switch back to using the safer `v1.tagKeys` and `v1.tagValues` functions directly. [0]: https://github.com/influxdata/flux/blob/master/stdlib/influxdata/influxdb/v1/v1.flux [1]: influxdata/flux#1071 Closes #13660
jpacik
approved these changes
Apr 26, 2019
121watts
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, slight changes in the form of a Flux metaquery can have drastic performance implications. To solve this issue, the Flux language provides helper metaquery functions such as
v1.tagKeysandv1.tagValueswhich are guaranteed to be as fast as possible.In #12791, we switched away from using the
v1.tagKeysandv1.tagValuesfunctions in the query builder to their underlying Flux implementations in order to implement a UI feature. While the new metaqueries used in the query builder were still optimized at the time, the Flux language has since changed and this is no longer the case.In addition, the metaqueries in the UI no longer hit the same code-path in Flux which has exposed a logic bug in the queries. So when executed, the metaqueries return the following error:
This PR updates the metaqueries used in the query builder to their currently optimized form. The long term solution is to address this issue and then switch back to using the safer
v1.tagKeysandv1.tagValuesfunctions directly.Closes #13660