Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): fixed auth userid overwrite #14344

Merged
merged 1 commit into from
Jul 15, 2019
Merged

fix(http): fixed auth userid overwrite #14344

merged 1 commit into from
Jul 15, 2019

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Jul 15, 2019

Closes #14202

fix the issue. Keep the logic if userid is not present in post auth request, use the current user id

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@kelwang kelwang requested a review from a team July 15, 2019 18:11
@ghost ghost requested review from lisale0 and removed request for a team July 15, 2019 18:11
@kelwang kelwang requested review from jacobmarble and a team and removed request for lisale0 July 15, 2019 18:11
jacobmarble
jacobmarble approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@jacobmarble jacobmarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kelwang kelwang merged commit d45bd1b into master Jul 15, 2019
@kelwang kelwang deleted the auth_create_user_fix branch July 15, 2019 18:19
@kelwang kelwang mentioned this pull request Jul 16, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmarble jacobmarble jacobmarble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create an auth associated with another user
2 participants
@kelwang @jacobmarble