Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/influx): add cli testing framework #14366

Closed
wants to merge 1 commit into from
Closed

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Jul 17, 2019

This PR is the CLI testing framework. and example of user subcommand.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

What would be really awesome is if we did proper integration testing by running an in-memory influxdb (influxd --store=memory --e2e-testing). Because the http service is mocked, this is testing a fairly thin layer: our cobra configuration. I think 99% of our cli regressions will be caused by underlying changes to kv, which would only be caught by integration testing.

Thoughts?

@goller goller removed their request for review October 31, 2019 01:24
@stale
Copy link

stale bot commented Jan 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 29, 2020
@stale
Copy link

stale bot commented Feb 5, 2020

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.

@stale stale bot closed this Feb 5, 2020
@jacobmarble jacobmarble deleted the cli_test_framework branch January 2, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants