Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): fix update timestamps, fix onboarding button, and create client libraries page #14846

Merged
merged 5 commits into from
Aug 28, 2019
Merged

refactor(ui): fix update timestamps, fix onboarding button, and create client libraries page #14846

merged 5 commits into from
Aug 28, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Aug 28, 2019 •
edited

Closes #14839
Closes #14827
Closes #14748

  • Make Telegraf explainer widget appear to the right of the list instead of below
  • Ensure onboarding "advanced" button goes to correct location
  • Standardize formatting of updated at timestamps in resource cards
  • Introduce "Client Libraries" page
    • Feature flag name: clientLibrariesPage
    • Uses mock data & type
    • Intentionally left very plain in anticipation of an actual design for this page

Screen Shot 2019-08-28 at 9 03 07 AM
Screen Shot 2019-08-28 at 1 10 23 PM
Screen Shot 2019-08-28 at 1 10 28 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team August 28, 2019 20:16
@ghost ghost requested review from 121watts and removed request for a team August 28, 2019 20:16
@alexpaxton alexpaxton merged commit 9d2466d into master Aug 28, 2019
@alexpaxton alexpaxton deleted the refactor/misc-ui-polish branch August 28, 2019 23:03
e-dard pushed a commit that referenced this pull request Aug 30, 2019
@alexpaxton @e-dard
refactor(ui): fix update timestamps, fix onboarding button, and creat…
0b95a28 
…e client libraries page (#14846)

* refactor(ui): make telegraf explainer less janky

* fix(ui): ensure onboarding "advanced" button goes to correct location

* refactor(ui): standardize formatting of updatedAt timestamps

* refactor(ui): introduce "client libraries" page with mock data behind a feature flag

* chore(ui): update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexpaxton @121watts