Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add shortcut for commenting in script editor #15313

Merged
merged 4 commits into from
Oct 3, 2019
Merged

feat(ui): Add shortcut for commenting in script editor #15313

merged 4 commits into from
Oct 3, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Oct 3, 2019 •
edited

Add commenting shortcut to the script editor.
Show shortcuts in question mark tooltip

editor_commenting

@drdelambre drdelambre requested a review from a team October 3, 2019 20:19
@drdelambre
Copy link
Contributor

comments above withstanding, looks good to me :shipit:

@ischolten ischolten merged commit f4dabb7 into master Oct 3, 2019
@ischolten ischolten deleted the comment-shortcut branch October 3, 2019 21:42
@noramullen1 noramullen1 mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping left review comments

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ischolten @drdelambre @hoorayimhelping @ebb-tide