fix: Disable saving threshold check if no threshold selected #15348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
changed the title
ebb-tide
changed the title
ebb-tide
changed the title
ghost
requested review from
ebb-tide
force-pushed
the
bugfix-check-saving
branch
from
bc80436
to
b67a262
Compare
ebb-tide
force-pushed
the
bugfix-check-saving
branch
from
ed64f29
to
7aaa322
Compare
| const oneOrMoreThresholds = | ||
| check.type === 'threshold' | ||
| ? check.thresholds && !!check.thresholds.length | ||
| : null |
There was a problem hiding this comment.
i think this should be false, not null. CheckEOSaveButton is expecting oneOrMoreThresholds to be a boolean and making this explicitly false will let us not rely on JS's sometimes confusing type casting. what do you think?
| @@ -98,6 +98,10 @@ const CheckEOHeader: FC<Props> = ({ | |||
| } | |||
|
|
|||
| const {singleField, singleAggregateFunc} = isDraftQueryAlertable(draftQueries) | |||
| const oneOrMoreThresholds = | |||
| check.type === 'threshold' | |||
| ? check.thresholds && !!check.thresholds.length | |||
There was a problem hiding this comment.
do we prefer !! over Boolean()?
There was a problem hiding this comment.
no strong preference but !! feels more readable?
hoorayimhelping
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Prevent check saving if no thresholds * Add tests * Add changes to changelog * make optional props optional * use false instead of null for boolean
hoorayimhelping
added a commit
that referenced
this pull request
Oct 8, 2019
add test for hydrateVars dashboard variable dropdown test: inspect values, not just array length add RTL test for variable dropdown changes lint fix: Disable saving threshold check if no threshold selected (#15348) * Prevent check saving if no thresholds * Add tests * Add changes to changelog * make optional props optional * use false instead of null for boolean changelog fix(ui): ignore false change events in VariableForm (#15317) closes #15059 the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15334
Describe your proposed changes here.
Disable saving threshold check if no threshold is selected