fix(vault): rename flags to match env vars and add missing token flag #15526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the flags have to match the flags with the exception of beign lower case and all `_` be changed to `-` in the flag. This is a result of using the cobra flag to env var mapping with the `-` replaced to `_`.
jsteenb2
force-pushed
the
4447/fix_vault_flag_names
branch
from
7db29ce
to
1bacb62
Compare
dearyhud
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the flags have to match the flags with the exception of beign lower case and
all
_be changed to-in the flag. This is a result of using the cobraflag to env var mapping with the
-replaced to_.