feat(ui): adding the ability to view just the output section #15674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 30, 2019 15:14
…egraf config for v2
Merge branch 'master' of github.com:influxdata/influxdb into alex_templated_snippets
Merge branch 'master' of github.com:influxdata/influxdb into alex_templated_snippets
Merge branch 'alex_templated_snippets' of github.com:influxdata/influxdb into alex_feat_new_overlay
added 11 commits
October 31, 2019 15:00
Merge remote-tracking branch 'origin/master' into alex_feat_new_overlay
Merge branch 'master' of github.com:influxdata/influxdb into alex_feat_new_overlay
This reverts commit 63171fd.
drdelambre
commented
Nov 6, 2019
| @@ -1,5 +1,8 @@ | |||
| import {Organization} from '../../src/types' | |||
|
|
|||
| // a generous commitment to delivering this page in a loaded state | |||
| const PAGE_LOAD_SLA = 10000 | |||
There was a problem hiding this comment.
this just unbreaks the test locally for me
There was a problem hiding this comment.
Makes sense, gives it more time to load
drdelambre
commented
Nov 6, 2019
| .should('have.length', 0) | ||
| .then(() => { | ||
| cy.contains('Create Configuration') | ||
| cy.getByTestID('table-row').should('have.length', 0) |
There was a problem hiding this comment.
i just moved this test outside of the then
added 3 commits
November 6, 2019 10:37
Merge branch 'master' of github.com:influxdata/influxdb into alex_feat_new_overlay
drdelambre
commented
Nov 6, 2019
| @@ -18,6 +21,7 @@ describe('Checks', () => { | |||
| cy.visit(`${orgs}/${id}${alerting}`) | |||
| }) | |||
| }) | |||
| cy.get('[data-testid="resource-list--body"]', {timeout: PAGE_LOAD_SLA}) | |||
There was a problem hiding this comment.
wait for a test agnostic load event to signal that the tests are ready to run
drdelambre
commented
Nov 6, 2019
| @@ -76,6 +117,7 @@ describe('Collectors', () => { | |||
| }) | |||
|
|
|||
| cy.reload() | |||
| cy.get('[data-testid="resource-list--body"]', {timeout: PAGE_LOAD_SLA}) | |||
There was a problem hiding this comment.
always gotta wait for that page to be ready 😬
drdelambre
commented
Nov 6, 2019
| cy.getByTestID('bucket-sorter') | ||
| .click() | ||
| .then(() => { | ||
| bucketz.sort() | ||
| // NOTE: this then is just here to let me scope this variable (alex) |
There was a problem hiding this comment.
or else it's mutation falls outside of the magic promise chain
zoesteinkamp
approved these changes
Nov 6, 2019
| @@ -1,5 +1,8 @@ | |||
| import {Organization} from '../../src/types' | |||
|
|
|||
| // a generous commitment to delivering this page in a loaded state | |||
| const PAGE_LOAD_SLA = 10000 | |||
There was a problem hiding this comment.
Makes sense, gives it more time to load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14924
Added a popup on a route, activated by a button, to help users view just the parts of the telegraf config required for migrating to V2.