Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): fake flux deps #15713

Merged
merged 1 commit into from
Nov 8, 2019
Merged

fix(tasks): fake flux deps #15713

merged 1 commit into from
Nov 8, 2019

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented Nov 1, 2019

Closes #15583

Wire fake flux dependencies to allow use of http.post, etc. in tasks.

@gavincabbage
Copy link
Contributor Author

Will require a flux upgrade to incorporate influxdata/flux#2086

Copy link

@Tonii80 Tonii80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syy The duck se are doing this?

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @gavincabbage; and 💯 for adding UI tests!

@gavincabbage gavincabbage merged commit 3e29464 into master Nov 8, 2019
@gavincabbage gavincabbage deleted the fix/http-deps branch November 8, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of http.Post impossible inside tasks
4 participants