Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(depedencies): use http client interface #2086

Merged
merged 1 commit into from
Nov 1, 2019
Merged

refactor(depedencies): use http client interface #2086

merged 1 commit into from
Nov 1, 2019

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented Nov 1, 2019 •
edited
Loading

Replace concrete *http.Client dependency with an interface.

Necessary for influxdata/influxdb#15713

@gavincabbage gavincabbage requested a review from a team November 1, 2019 15:33
@ghost ghost requested review from fchikwekwe and removed request for a team November 1, 2019 15:34
@gavincabbage gavincabbage mentioned this pull request Nov 1, 2019
Merged
4 tasks
fchikwekwe
fchikwekwe approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@fchikwekwe fchikwekwe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty reasonable and straightforward change to me. I took a look at the other PR and I can see the overlap. LGTM.

@gavincabbage gavincabbage merged commit dc76b18 into master Nov 1, 2019
@gavincabbage gavincabbage deleted the refactor/http-dep branch November 1, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchikwekwe fchikwekwe fchikwekwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavincabbage @fchikwekwe